From: Keir Fraser Date: Wed, 1 Sep 2010 09:16:39 +0000 (+0100) Subject: x86 p2m: Fix comment regarding mfn_valid(). X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~11557 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=bbfcb03ac21705edc6b9f8e6abfddfff109de514;p=xen.git x86 p2m: Fix comment regarding mfn_valid(). MMIO pages are not always above max_page (e.g., >=4GB system with MMIO in the RAM hole below 4GB). Signed-off-by: Keir Fraser --- diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 7c0373effe..33bcc0dcea 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -2621,7 +2621,7 @@ clear_mmio_p2m_entry(struct p2m_domain *p2m, unsigned long gfn) mfn = gfn_to_mfn(p2m, gfn, &t); - /* Do not use mfn_valid() here as MMIO pages are always above max_page */ + /* Do not use mfn_valid() here as it will usually fail for MMIO pages. */ if ( (INVALID_MFN == mfn_x(mfn)) || (t != p2m_mmio_direct) ) { gdprintk(XENLOG_ERR,